fix: stringify less when processing recordindgs #20943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went poking around looking for what might be causing the reported problems where replay eventually becomes laggy
Nothing significant discovered yet but when looking at the profiles of the page
deduplicateSnapshots
was drowning out other function calls.We call deduplicateSnapshots many times and merge existing snapshots with any new ones, then stringify each so that we can identify and remove duplicates
We can store the calculated key so that we only do the potentially expensive calculation once per item
We could move the hash into the logic's cache so that we don't need to reprocess existing items - but that's not a last thing in the day fix
This is a quick patch to process items less. After which
deduplicateSnapshots
doesn't show as a significant function call in page profiles